Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 295373003: Reland 21482 - "Merge v8globals.h and globals.h" (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reland 21482 - "Merge v8globals.h and globals.h" > BUG=none > R=mstarzinger@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/293363006 BUG=none TBR=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -577 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/accessors.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/circular-queue.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 2 chunks +541 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sampler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/small-pointer-list.h View 1 chunk +1 line, -1 line 0 comments Download
M src/store-buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.h View 1 chunk +1 line, -1 line 0 comments Download
D src/v8globals.h View 1 chunk +0 lines, -559 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 09:52:57 UTC) #1
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 11:28:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r21490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698