Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: pkg/front_end/tool/perf.dart

Issue 2953703002: Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service (Closed)
Patch Set: cl review updates: cleanup in kernel deserialization Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/tool/fasta_perf.dart ('k') | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/tool/perf.dart
diff --git a/pkg/front_end/tool/perf.dart b/pkg/front_end/tool/perf.dart
index d5bc9255b89fce189976f8753f367449782ff283..4f77597e711614f8e200e611c41159b1f311353c 100644
--- a/pkg/front_end/tool/perf.dart
+++ b/pkg/front_end/tool/perf.dart
@@ -145,9 +145,6 @@ Future<Program> generateKernel(Uri entryUri,
_kernelForProgramViaDartk(Uri source, CompilerOptions options) async {
var loader = await _createLoader(options, entry: source);
- if (options.compileSdk) {
- options.additionalLibraries.forEach(loader.loadLibrary);
- }
loader.loadProgram(source, compileSdk: options.compileSdk);
_reportErrors(loader.errors, options.onError);
return loader.program;
@@ -170,8 +167,8 @@ Future<DartLoader> _createLoader(CompilerOptions options,
// URIs correctly even if sdkRoot is inferred and not specified explicitly.
String resolve(Uri patch) => _uriToPath(options.sdkRoot.resolveUri(patch));
- options.targetPatches.forEach((uri, patches) {
- patchPaths['$uri'] = patches.map(resolve).toList();
+ options.targetPatches.forEach((name, patches) {
+ patchPaths['dart:$name'] = patches.map(resolve).toList();
});
AnalysisOptionsImpl analysisOptions = loader.context.analysisOptions;
analysisOptions.patchPaths = patchPaths;
@@ -186,7 +183,6 @@ DartOptions _convertOptions(CompilerOptions options) {
// sdk sources.
sdkSummary: options.compileSdk ? null : _uriToPath(options.sdkSummary),
packagePath: _uriToPath(options.packagesFileUri),
- customUriMappings: options.uriOverride,
declaredVariables: options.declaredVariables);
}
« no previous file with comments | « pkg/front_end/tool/fasta_perf.dart ('k') | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698