Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service

pkg/kernel/lib/binary/limited_ast_to_binary.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart';
 import 'package:kernel/binary/ast_to_binary.dart';
 
 /// Writes libraries that satisfy the [predicate].
 ///
 /// Only the referenced subset of canonical names is indexed and written,
 /// so we don't waste time indexing all libraries of a program, when only
 /// a tiny subset is used.
 class LimitedBinaryPrinter extends BinaryPrinter {
   final LibraryFilter predicate;
 
-  LimitedBinaryPrinter(Sink<List<int>> sink, this.predicate)
+  /// Excludes also all uriToSource information.

[ahe, 2017/07/06 13:12:22]

"also" implies a context that's kinda missing here.

I'd try something like this:

/// Exclues all uriToSource information in addition to ... (what?).

[Siggi Cherem (dart-lang), 2017/07/06 19:05:28]

Done.

The "what" was is basically everything this class does :) - excluding code and
canonical names for filtered libraries.

+  // TODO(sigmund): provide a way to filter sources based on their
+  // corresponding libraries (or the filter specified above).
+  final bool excludeUriToSource;
+
+  LimitedBinaryPrinter(
+      Sink<List<int>> sink, this.predicate, this.excludeUriToSource)
       : super(sink, stringIndexer: new ReferencesStringIndexer());
 
   @override
   void computeCanonicalNames(Program program) {
     for (var library in program.libraries) {
       if (predicate(library)) {
         program.root
             .getChildFromUri(library.importUri)
             .bindTo(library.reference);
         library.computeCanonicalNames();
@@ skipping 28 matching lines @@
   void writeLibraries(Program program) {
     var librariesToWrite = program.libraries.where(predicate).toList();
     writeList(librariesToWrite, writeNode);
   }
 
   @override
   void writeNode(Node node) {
     if (node is Library && !predicate(node)) return;
     node.accept(this);
   }
+
+  @override
+  void writeUriToSource(Program program) {
+    if (!excludeUriToSource) {
+      super.writeUriToSource(program);
+    } else {
+      // Emit a practically empty uriToSrouce table.
+      writeStringTable(new StringIndexer());
+
+      // Add an entry for '', which is always included by default.
+      writeUtf8Bytes(const <int>[]);
+      writeUInt30(0);
+    }
+  }
 }
 
 /// Extension of [StringIndexer] that also indexes canonical names of
 /// referenced classes and members.
 class ReferencesStringIndexer extends StringIndexer {
   final List<CanonicalName> referencedNames = <CanonicalName>[];
 
   @override
   defaultMemberReference(Member node) {
     _handleReferencedName(node.canonicalName);
@@ skipping 41 matching lines @@
   }
 
   void _handleReferencedName(CanonicalName name) {
     if (name == null || name.parent == null) return;
     _handleReferencedName(name.parent);
     referencedNames.add(name);
     name.index = -1;
     put(name.name);
   }
 }