pkg/front_end/lib/src/simple_error.dart - Issue 2953703002: Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/front_end/lib/src/simple_error.dart

Issue 2953703002: Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« pkg/front_end/lib/src/kernel_generator_impl.dart ('K') | « pkg/front_end/lib/src/kernel_generator_impl.dart ('k') | pkg/front_end/lib/src/testing/compiler_common.dart » ('j') | pkg/front_end/lib/src/testing/compiler_common.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 import 'package:front_end/compilation_error.dart';	1 import 'package:front_end/compilation_error.dart';

2	2

3 import 'package:source_span/source_span.dart' show SourceSpan;	3 import 'package:source_span/source_span.dart' show SourceSpan;

4	4

5 /// An error that only contains a message and no error location.	5 /// An error that only contains a message and no error location.
	ahe 2017/07/05 13:29:40 I would assume this should still have an error cod I would assume this should still have an error code, right? Siggi Cherem (dart-lang) 2017/07/05 18:42:11 Good point - for now added a TODO and will follow Show quoted text On 2017/07/05 13:29:40, ahe wrote: > I would assume this should still have an error code, right? Good point - for now added a TODO and will follow up with a new CL. I should add all the errors that are currently strings in ProcessedOptions and generateKernel to messages.yaml and autogenerate their error object instead.
6 class SimpleError implements CompilationError {	6 class SimpleError implements CompilationError {

7 String get correction => null;	7 String get correction => null;

8 SourceSpan get span => null;	8 SourceSpan get span => null;

9 final String message;	9 final String message;

10 SimpleError(this.message);	10 SimpleError(this.message);

	11

	12 String toString() => "FrontEnd Error: $message";
	ahe 2017/07/05 13:29:40 I'm not sure how the user experience is improved b I'm not sure how the user experience is improved by adding "FrontEnd Error: " to the message. Siggi Cherem (dart-lang) 2017/07/05 18:42:11 Done. Show quoted text On 2017/07/05 13:29:40, ahe wrote: > I'm not sure how the user experience is improved by adding "FrontEnd Error: " to > the message. Done.
11 }	13 }

OLD	NEW