Issue 2953653002: [arm, arm64] Convince the Android toolchain not to bypass memcpy in Read/StoreUnaligned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2953653002: [arm, arm64] Convince the Android toolchain not to bypass memcpy in Read/StoreUnaligned. (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

[arm, arm64] Convince the Android toolchain not to bypass memcpy in Read/StoreUnaligned. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/e1b31c6b4bc623149d1a8d3dd3816bbd3de60ff3

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/platform/globals.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Committed patchset #1 (id:1) manually as e1b31c6b4bc623149d1a8d3dd3816bbd3de60ff3 (presubmit successful).

3 years, 6 months ago (2017-06-21 21:03:56 UTC) #5

rmacnak

3 years, 6 months ago (2017-06-21 21:04:57 UTC) #6

Message was sent while issue was closed.

At this time the ARM Linux toolchain is gcc and the ARM Android toolchain is
clang, so it may be a gcc versus clang thing instead of Linux verus Android.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages