Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: runtime/vm/service.cc

Issue 295353002: Fix pause-on-start and pause-on-exit with async loading. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/globals.h" 8 #include "platform/globals.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 if (create_callback == NULL) { 322 if (create_callback == NULL) {
323 return NULL; 323 return NULL;
324 } 324 }
325 Isolate::SetCurrent(NULL); 325 Isolate::SetCurrent(NULL);
326 char* error = NULL; 326 char* error = NULL;
327 Isolate* isolate = reinterpret_cast<Isolate*>( 327 Isolate* isolate = reinterpret_cast<Isolate*>(
328 create_callback(callback_data, &error)); 328 create_callback(callback_data, &error));
329 if (isolate == NULL) { 329 if (isolate == NULL) {
330 return NULL; 330 return NULL;
331 } 331 }
332 // We don't want to pause the service isolate.
333 isolate->message_handler()->set_pause_on_start(false);
334 isolate->message_handler()->set_pause_on_exit(false);
335 Isolate::SetCurrent(isolate); 332 Isolate::SetCurrent(isolate);
336 { 333 {
337 // Install the dart:vmservice library. 334 // Install the dart:vmservice library.
338 StackZone zone(isolate); 335 StackZone zone(isolate);
339 HANDLESCOPE(isolate); 336 HANDLESCOPE(isolate);
340 Library& library = 337 Library& library =
341 Library::Handle(isolate, isolate->object_store()->root_library()); 338 Library::Handle(isolate, isolate->object_store()->root_library());
342 // Isolate is empty. 339 // Isolate is empty.
343 ASSERT(library.IsNull()); 340 ASSERT(library.IsNull());
344 // Grab embedder tag handler. 341 // Grab embedder tag handler.
(...skipping 1722 matching lines...) Expand 10 before | Expand all | Expand 10 after
2067 while (current != NULL) { 2064 while (current != NULL) {
2068 if (strcmp(name, current->name()) == 0) { 2065 if (strcmp(name, current->name()) == 0) {
2069 return current; 2066 return current;
2070 } 2067 }
2071 current = current->next(); 2068 current = current->next();
2072 } 2069 }
2073 return NULL; 2070 return NULL;
2074 } 2071 }
2075 2072
2076 } // namespace dart 2073 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698