Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2953513002: Fix a race between navigation and an interstitial. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 1f07ec664e0b2f0f212e746e2fb5d89d9d80db42..90d3a376f7f41b52d07e6fbe99473e575a380802 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1882,8 +1882,10 @@ void NavigationControllerImpl::NavigateToPendingEntry(ReloadType reload_type) {
// If an interstitial page is showing, we want to close it to get back
Charlie Reis 2017/06/21 06:02:31 "is showing or is about to show"? (It's worth clar
// to what was showing before.
- if (delegate_->GetInterstitialPage())
- delegate_->GetInterstitialPage()->DontProceed();
+ InterstitialPage* interstitial =
+ InterstitialPage::GetInterstitialPage(GetWebContents());
+ if (interstitial)
+ interstitial->DontProceed();
DiscardNonCommittedEntries();
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698