Transfer ownership of InputMethodController from LocalFrame to DOMWindow

Transfer ownership of InputMethodController from LocalFrame to DOMWindow

Since lifetime of InputMethodController is same as a DOMWindow, so
we can move the ownership to DOMWindow.

BUG=695359

[tanvir, 2017-06-22 14:11:12]

Description was changed from

==========
Transfer ownership of InputMethodController from LocalFrame to DomWindow

Since lifetime of InputMethodController is same as a DomWindow, so
we can move the ownership to DomWindow.

BUG=695359
==========

to

==========
Transfer ownership of InputMethodController from LocalFrame to DomWindow

Since lifetime of InputMethodController is same as a DomWindow, so
we can move the ownership to DomWindow.

BUG=695359
==========

[tanvir, 2017-06-22 14:11:12]

tanvir.rizvi@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@samsung.com

[Srirama, 2017-06-22 14:13:29]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 14:13:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Srirama, 2017-06-22 14:15:39]

nit: s/DomWindow/DOMWindow in description

[tanvir, 2017-06-22 14:19:05]

Description was changed from

==========
Transfer ownership of InputMethodController from LocalFrame to DomWindow

Since lifetime of InputMethodController is same as a DomWindow, so
we can move the ownership to DomWindow.

BUG=695359
==========

to

==========
Transfer ownership of InputMethodController from LocalFrame to DomWindow

Since lifetime of InputMethodController is same as a DOMWindow, so
we can move the ownership to DOMWindow.

BUG=695359
==========

[tanvir, 2017-06-22 14:19:23]

Description was changed from

==========
Transfer ownership of InputMethodController from LocalFrame to DomWindow

Since lifetime of InputMethodController is same as a DOMWindow, so
we can move the ownership to DOMWindow.

BUG=695359
==========

to

==========
Transfer ownership of InputMethodController from LocalFrame to DOMWindow

Since lifetime of InputMethodController is same as a DOMWindow, so
we can move the ownership to DOMWindow.

BUG=695359
==========

[commit-bot: I haz the power, 2017-06-22 19:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 19:01:07]

Dry run: This issue passed the CQ dry run.

[tanvir, 2017-06-23 04:38:46]

tanvir.rizvi@samsung.com changed reviewers:
+ yosin@chromium.org

[tanvir, 2017-06-23 04:38:46]

PTAL!!!
Thanks

[yosin_UTC9, 2017-06-23 05:12:27]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-06-23 05:12:27]

non-owner lgtm

+tkent@ for OWNERS review.

[tkent, 2017-06-23 05:16:55]

Does this CL any practical benefit?
Because we can't use IME without a frame, IMController owned by Frame looks
reasonable to me.

[tkent, 2017-06-23 05:17:12]

On 2017/06/23 at 05:16:55, tkent wrote:
> Does this CL any practical benefit?


CL any -> CL have any

[yosin_UTC9, 2017-06-23 05:45:39]

On 2017/06/23 at 05:17:12, tkent wrote:
> On 2017/06/23 at 05:16:55, tkent wrote:
> > Does this CL any practical benefit?
> 
> 
> CL any -> CL have any

Fumm..., it is better to make Document to own InputMethodController instead of
DOMWindow to
make IMC not to inherit |SynchronousMutationObserver|, actually we should use
|DocumentShtudoDownObserver| though.
IMC should clear |composition_range_| when Document is unavailable. If lifetime
of IMC is as same as DOcument,
we don't need to clear |composition_range_| explicitly.

Yet another option is make Page as owner of IMC since IMC is called only for
active frame.

[tkent, 2017-06-23 06:04:21]

On 2017/06/23 at 05:45:39, yosin wrote:
> Fumm..., it is better to make Document to own InputMethodController instead of
DOMWindow to
> make IMC not to inherit |SynchronousMutationObserver|, actually we should use
|DocumentShtudoDownObserver| though.
> IMC should clear |composition_range_| when Document is unavailable. If
lifetime of IMC is as same as DOcument,
> we don't need to clear |composition_range_| explicitly.
> 
> Yet another option is make Page as owner of IMC since IMC is called only for
active frame.

Document without Frame doesn't need InputMethodController.
IMC owned by Page makes sense.  Also, how about IMC owned by Editor?

[tkent, 2017-06-23 06:11:02]

On 2017/06/23 at 06:04:21, tkent wrote:
> On 2017/06/23 at 05:45:39, yosin wrote:
> > Fumm..., it is better to make Document to own InputMethodController instead
of DOMWindow to
> > make IMC not to inherit |SynchronousMutationObserver|, actually we should
use |DocumentShtudoDownObserver| though.
> > IMC should clear |composition_range_| when Document is unavailable. If
lifetime of IMC is as same as DOcument,
> > we don't need to clear |composition_range_| explicitly.
> > 
> > Yet another option is make Page as owner of IMC since IMC is called only for
active frame.
> 
> Document without Frame doesn't need InputMethodController.
> IMC owned by Page makes sense.  Also, how about IMC owned by Editor?

IMC owned by Page might need OOPIF consideration.

[yosin_UTC9, 2017-06-23 06:45:45]

On 2017/06/23 at 06:11:02, tkent wrote:
> On 2017/06/23 at 06:04:21, tkent wrote:
> > On 2017/06/23 at 05:45:39, yosin wrote:
> > > Fumm..., it is better to make Document to own InputMethodController
instead of DOMWindow to
> > > make IMC not to inherit |SynchronousMutationObserver|, actually we should
use |DocumentShtudoDownObserver| though.
> > > IMC should clear |composition_range_| when Document is unavailable. If
lifetime of IMC is as same as DOcument,
> > > we don't need to clear |composition_range_| explicitly.
> > > 
> > > Yet another option is make Page as owner of IMC since IMC is called only
for active frame.
> > 
> > Document without Frame doesn't need InputMethodController.
> > IMC owned by Page makes sense.  Also, how about IMC owned by Editor?
> 
> IMC owned by Page might need OOPIF consideration.

+1 for Editor, like SpellChecker owns IdleSpellCheckCallback.