Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2953473002: Use leveldb_env::OpenDB() to open leveldb databases. (Closed)
Patch Set: Use OpenDB in unittests; add allocation edges Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/history_report/delta_file_backend_leveldb.cc » ('j') | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3ab7802f7a1e48f75b43a2d020e4404164917a88..5fb374af71b6e04f4d40fe6fc07c3c41e2af0943 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -384,6 +384,18 @@ _BANNED_CPP_FUNCTIONS = (
r'^content[\\\/]public[\\\/]test[\\\/]test_web_ui\.(cc|h)$',
),
),
+ (
+ 'leveldb::DB::Open',
+ (
+ 'Instead of leveldb::DB::Open() use leveldb_env::OpenDB() from',
+ 'third_party/leveldatabase/env_chromium.h. It exposes databases to',
+ "Chrome's tracing, making their memory usage visible.",
+ ),
+ True,
+ (
+ r'^third_party/leveldatabase/.*\.(cc|h)$',
+ ),
+ )
)
« no previous file with comments | « no previous file | chrome/browser/android/history_report/delta_file_backend_leveldb.cc » ('j') | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698