Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: google_apis/gcm/engine/gcm_store_impl.cc

Issue 2953473002: Use leveldb_env::OpenDB() to open leveldb databases. (Closed)
Patch Set: Don't dump in background mode Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/gcm_store_impl.cc
diff --git a/google_apis/gcm/engine/gcm_store_impl.cc b/google_apis/gcm/engine/gcm_store_impl.cc
index 59600a1152460bcf99a344a9f174c7568e60143c..312caf277a5eb2289f51e2c4acda1544d8b3d135 100644
--- a/google_apis/gcm/engine/gcm_store_impl.cc
+++ b/google_apis/gcm/engine/gcm_store_impl.cc
@@ -303,9 +303,8 @@ LoadStatus GCMStoreImpl::Backend::OpenStoreAndLoadData(StoreOpenMode open_mode,
options.create_if_missing = open_mode == CREATE_IF_MISSING;
options.reuse_logs = leveldb_env::kDefaultLogReuseOptionValue;
options.paranoid_checks = true;
- leveldb::DB* db;
leveldb::Status status =
- leveldb::DB::Open(options, path_.AsUTF8Unsafe(), &db);
+ leveldb_env::OpenDB(options, path_.AsUTF8Unsafe(), &db_);
UMA_HISTOGRAM_ENUMERATION("GCM.Database.Open",
leveldb_env::GetLevelDBStatusUMAValue(status),
leveldb_env::LEVELDB_STATUS_MAX);
@@ -315,7 +314,6 @@ LoadStatus GCMStoreImpl::Backend::OpenStoreAndLoadData(StoreOpenMode open_mode,
return OPENING_STORE_FAILED;
}
- db_.reset(db);
if (!LoadDeviceCredentials(&result->device_android_id,
&result->device_security_token)) {
return LOADING_DEVICE_CREDENTIALS_FAILED;

Powered by Google App Engine
This is Rietveld 408576698