Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc

Issue 2953473002: Use leveldb_env::OpenDB() to open leveldb databases. (Closed)
Patch Set: Rebase; add comments to CHECK() Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h" 5 #include "chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/files/scoped_temp_dir.h" 11 #include "base/files/scoped_temp_dir.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/strings/string_number_conversions.h" 15 #include "base/strings/string_number_conversions.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include "third_party/leveldatabase/env_chromium.h"
17 #include "third_party/leveldatabase/src/helpers/memenv/memenv.h" 18 #include "third_party/leveldatabase/src/helpers/memenv/memenv.h"
18 #include "third_party/leveldatabase/src/include/leveldb/db.h" 19 #include "third_party/leveldatabase/src/include/leveldb/db.h"
19 #include "third_party/leveldatabase/src/include/leveldb/env.h" 20 #include "third_party/leveldatabase/src/include/leveldb/env.h"
20 21
21 namespace sync_file_system { 22 namespace sync_file_system {
22 namespace drive_backend { 23 namespace drive_backend {
23 24
24 struct TestData { 25 struct TestData {
25 const std::string key; 26 const std::string key;
26 const std::string value; 27 const std::string value;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 ASSERT_TRUE(itr->Valid()); 68 ASSERT_TRUE(itr->Valid());
68 EXPECT_EQ(expects[i].key, itr->key().ToString()); 69 EXPECT_EQ(expects[i].key, itr->key().ToString());
69 EXPECT_EQ(expects[i].value, itr->value().ToString()); 70 EXPECT_EQ(expects[i].value, itr->value().ToString());
70 itr->Next(); 71 itr->Next();
71 } 72 }
72 EXPECT_FALSE(itr->Valid()); 73 EXPECT_FALSE(itr->Valid());
73 } 74 }
74 75
75 private: 76 private:
76 void InitializeLevelDB() { 77 void InitializeLevelDB() {
77 leveldb::DB* db = nullptr; 78 std::unique_ptr<leveldb::DB> db;
78 leveldb::Options options; 79 leveldb::Options options;
79 options.create_if_missing = true; 80 options.create_if_missing = true;
80 options.max_open_files = 0; // Use minimum. 81 options.max_open_files = 0; // Use minimum.
81 options.env = in_memory_env_.get(); 82 options.env = in_memory_env_.get();
82 leveldb::Status status = 83 leveldb::Status status = leveldb_env::OpenDB(
83 leveldb::DB::Open(options, database_dir_.GetPath().AsUTF8Unsafe(), &db); 84 options, database_dir_.GetPath().AsUTF8Unsafe(), &db);
84 ASSERT_TRUE(status.ok()); 85 ASSERT_TRUE(status.ok());
85 86
86 db_.reset(new LevelDBWrapper(base::WrapUnique(db))); 87 db_.reset(new LevelDBWrapper(std::move(db)));
87 } 88 }
88 89
89 base::ScopedTempDir database_dir_; 90 base::ScopedTempDir database_dir_;
90 std::unique_ptr<leveldb::Env> in_memory_env_; 91 std::unique_ptr<leveldb::Env> in_memory_env_;
91 std::unique_ptr<LevelDBWrapper> db_; 92 std::unique_ptr<LevelDBWrapper> db_;
92 }; 93 };
93 94
94 TEST_F(LevelDBWrapperTest, IteratorTest) { 95 TEST_F(LevelDBWrapperTest, IteratorTest) {
95 CreateDefaultDatabase(); 96 CreateDefaultDatabase();
96 std::unique_ptr<LevelDBWrapper::Iterator> itr = GetDB()->NewIterator(); 97 std::unique_ptr<LevelDBWrapper::Iterator> itr = GetDB()->NewIterator();
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 237
237 EXPECT_EQ(0, GetDB()->num_puts()); 238 EXPECT_EQ(0, GetDB()->num_puts());
238 EXPECT_EQ(0, GetDB()->num_deletes()); 239 EXPECT_EQ(0, GetDB()->num_deletes());
239 240
240 SCOPED_TRACE("DeleteTest_Commit"); 241 SCOPED_TRACE("DeleteTest_Commit");
241 CheckDBContents(merged_data, arraysize(merged_data)); 242 CheckDBContents(merged_data, arraysize(merged_data));
242 } 243 }
243 244
244 } // namespace drive_backend 245 } // namespace drive_backend
245 } // namespace sync_file_system 246 } // namespace sync_file_system
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698