[Extensions Bindings] Add access checks in custom types

extensions/renderer/chrome_setting.h

Index: extensions/renderer/chrome_setting.h
diff --git a/extensions/renderer/chrome_setting.h b/extensions/renderer/chrome_setting.h
index 11b7dc2c13ad68da769e9b14d5a1a5979f20d92a..4c9b45607bdc6d506e51d70111f5614ed31dfe94 100644
--- a/extensions/renderer/chrome_setting.h
+++ b/extensions/renderer/chrome_setting.h
@@ -24,6 +24,7 @@ class Arguments;
 namespace extensions {
 class APIEventHandler;
 class APIRequestHandler;
+class BindingAccessChecker;
 
 // The custom implementation of the ChromeSetting type exposed to APIs.
 class ChromeSetting final : public gin::Wrappable<ChromeSetting> {
@@ -31,12 +32,14 @@ class ChromeSetting final : public gin::Wrappable<ChromeSetting> {
   ~ChromeSetting() override;
 
   // Creates a ChromeSetting object for the given property.
-  static v8::Local<v8::Object> Create(v8::Isolate* isolate,
-                                      const std::string& property_name,
-                                      const base::ListValue* property_values,
-                                      APIRequestHandler* request_handler,
-                                      APIEventHandler* event_handler,
-                                      APITypeReferenceMap* type_refs);
+  static v8::Local<v8::Object> Create(
+      v8::Isolate* isolate,
+      const std::string& property_name,
+      const base::ListValue* property_values,
+      APIRequestHandler* request_handler,
+      APIEventHandler* event_handler,
+      APITypeReferenceMap* type_refs,
+      const BindingAccessChecker* access_checker);
 
   static gin::WrapperInfo kWrapperInfo;
 
@@ -47,6 +50,7 @@ class ChromeSetting final : public gin::Wrappable<ChromeSetting> {
   ChromeSetting(APIRequestHandler* request_handler,
                 APIEventHandler* event_handler,
                 const APITypeReferenceMap* type_refs,
+                const BindingAccessChecker* access_checker,
                 const std::string& pref_name,
                 const base::DictionaryValue& argument_spec);
 
@@ -68,6 +72,8 @@ class ChromeSetting final : public gin::Wrappable<ChromeSetting> {
 
   const APITypeReferenceMap* type_refs_;
 
+  const BindingAccessChecker* access_checker_;

[lazyboy, 2017/06/22 00:10:25]

nit: const BindingAccessChecker* 'const' access_checker_

[Devlin, 2017/06/22 15:49:55]

Done (also for storage_area and content_setting)

+
   // The name of the preference this ChromeSetting is managing.
   std::string pref_name_;