Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2953373002: [observatory] Add a 'GC' button to heap map. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 5 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, turnidge, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M runtime/observatory/lib/src/elements/heap_map.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/allocation_profile.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/observatory_tool.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-06-24 00:39:55 UTC) #2
cbernaschina
On 2017/06/24 00:39:55, rmacnak wrote: lgtm
3 years, 5 months ago (2017-06-29 16:57:25 UTC) #3
rmacnak
3 years, 5 months ago (2017-06-29 17:45:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
399ade26aacc224ba1329af99e76a33946d9b6dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698