Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

Issue 2953183004: Comment/test for DocumentMarkerList::MarkersIntersectingRange() with collapsed range (Closed)
Patch Set: Update comment, Empty => Collapsed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h
index b5890004ec5fcf3f2ba745189e4b9f942bd179fc..712da9993776af6b8d8fb862ccc09abac7880a29 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h
@@ -33,8 +33,9 @@ class CORE_EXPORT DocumentMarkerList
// Returns all markers
virtual const HeapVector<Member<DocumentMarker>>& GetMarkers() const = 0;
- // Returns markers that have non-empty overlap with the range
- // [start_offset, end_offset]
+ // Return markers whose interiors have non-empty overlap with the range
Xiaocheng 2017/06/23 21:40:32 nit: s/Return/Returns/ Sorry for my typo.
+ // [start_offset, end_offset]. Note that the range can be collapsed, in which
+ // case markers containing the offset in their interiors are returned.
virtual HeapVector<Member<DocumentMarker>> MarkersIntersectingRange(
unsigned start_offset,
unsigned end_offset) const = 0;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698