extensions/renderer/bindings/api_bindings_system_unittest.cc - Issue 2953133002: [Extensions Bindings] Support chrome.extension.lastError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/bindings/api_bindings_system_unittest.cc

Issue 2953133002: [Extensions Bindings] Support chrome.extension.lastError (Closed)

Patch Set: jbroman's, lazyboy's Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/bindings/api_bindings_system_unittest.cc

diff --git a/extensions/renderer/bindings/api_bindings_system_unittest.cc b/extensions/renderer/bindings/api_bindings_system_unittest.cc

index 1a63eca2324f29d53287d25b06e41f01715c3e1a..9d91c661305cb085dea683b6c265fe85cf2a02ad 100644

--- a/extensions/renderer/bindings/api_bindings_system_unittest.cc

+++ b/extensions/renderer/bindings/api_bindings_system_unittest.cc

@@ -144,7 +144,8 @@ std::vector<APIBindingsSystemTest::FakeSpec> APIBindingsSystemTest::GetAPIs() {

}

v8::Local<v8::Object> APIBindingsSystemTest::GetLastErrorParent(

- v8::Local<v8::Context> context) {

+ v8::Local<v8::Context> context,

+ v8::Local<v8::Object>* secondary_parent) {

return v8::Local<v8::Object>();

}