Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/renderer/api_bindings_system_unittest.h

Issue 2953133002: [Extensions Bindings] Support chrome.extension.lastError (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding_js_util_unittest.cc ('k') | extensions/renderer/api_bindings_system_unittest.cc » ('j') | extensions/renderer/api_last_error.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_bindings_system_unittest.h
diff --git a/extensions/renderer/api_bindings_system_unittest.h b/extensions/renderer/api_bindings_system_unittest.h
index 4f5deb8b8bada08f42e732eedd2a2227f477486b..e3b079e352c811d017e8f4387567287dc5612da7 100644
--- a/extensions/renderer/api_bindings_system_unittest.h
+++ b/extensions/renderer/api_bindings_system_unittest.h
@@ -48,7 +48,8 @@ class APIBindingsSystemTest : public APIBindingTest {
// Returns the object to be used as the parent for the `lastError`. The
// default returns an empty JS object (assumes no last errors will be set).
virtual v8::Local<v8::Object> GetLastErrorParent(
lazyboy 2017/06/27 17:58:44 Update documentation.
Devlin 2017/06/28 17:52:01 Done.
- v8::Local<v8::Context> context);
+ v8::Local<v8::Context> context,
+ v8::Local<v8::Object>* secondary_parent);
// Returns the DictionaryValue representing the schema with the given API
// name.
« no previous file with comments | « extensions/renderer/api_binding_js_util_unittest.cc ('k') | extensions/renderer/api_bindings_system_unittest.cc » ('j') | extensions/renderer/api_last_error.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698