chrome/browser/resources/settings/internet_page/network_ip_config.html - Issue 2953113002: Settings: Network: Always show IP info and fix layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_ip_config.html

Issue 2953113002: Settings: Network: Always show IP info and fix layout (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_shared_css.html ('k') | chrome/browser/resources/settings/internet_page/network_ip_config.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_ip_config.html

diff --git a/chrome/browser/resources/settings/internet_page/network_ip_config.html b/chrome/browser/resources/settings/internet_page/network_ip_config.html

index 520a72897e67582b635ee0fd63a3817e058fb19b..b59eaf68c6c3e2f24aaccb1f0dd46a931004693f 100644

--- a/chrome/browser/resources/settings/internet_page/network_ip_config.html

+++ b/chrome/browser/resources/settings/internet_page/network_ip_config.html

@@ -14,8 +14,8 @@

aria-labelledby="autoIPConfigLabel">

</paper-toggle-button>

</div>

- <div class="settings-box continuation"

- hidden$="[[!showIPEditFields_(editable, automatic_)]]">

+ <div class="settings-box single-column continuation indented stretch"

+ hidden$="[[!showIPEditFields_(networkProperties.IPConfigs)]]">

michaelpg 2017/06/23 22:33:12 since the function just checks !!foo, would [[!net

stevenjb 2017/06/23 23:27:43 Good point. Done.

<network-property-list

fields="[[ipConfigFields_]]" property-dict="[[ipConfig_]]"

edit-field-types="[[getIPEditFields_(editable, automatic_)]]"