Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart

Issue 2953093002: Update the plugin API (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart
diff --git a/pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart b/pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart
index 4f68255a4139cf337576abe23d1c0af8db6fbdf4..7896d832ad92a0e8b3cb96f5f8be75fe655d03b8 100644
--- a/pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart
+++ b/pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart
@@ -62,21 +62,21 @@ class CompletionCollectorImpl implements CompletionCollector {
}
@override
- void addSuggestion(CompletionSuggestion suggestion) {
- suggestions.add(suggestion);
- }
-
- @override
bool get offsetIsSet => offset != null;
@override
int get suggestionsLength => suggestions.length;
+
+ @override
+ void addSuggestion(CompletionSuggestion suggestion) {
+ suggestions.add(suggestion);
+ }
}
/**
- * Information about the completion request that was made.
- */
-class CompletionRequestImpl implements CompletionRequest {
+* A concrete implementation of [DartCompletionRequest].
+*/
+class CompletionRequestImpl implements DartCompletionRequest {
maxkim 2017/06/22 20:52:56 DartCompletionRequestImpl
Brian Wilkerson 2017/06/22 22:07:01 Done
@override
final int offset;

Powered by Google App Engine
This is Rietveld 408576698