[Extensions Bindings] Move loadTypeSchema from utils to json_schema

extensions/renderer/resources/binding.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var Event = require('event_bindings').Event;
 var forEach = require('utils').forEach;
 // Note: Beware sneaky getters/setters when using GetAvailbility(). Use safe/raw
 // variables as arguments.
 var GetAvailability = requireNative('v8_context').GetAvailability;
 var exceptionHandler = require('uncaught_exception_handler');
 var lastError = require('lastError');
+var loadTypeSchema = require('json_schema').loadTypeSchema;
 var logActivity = requireNative('activityLogger');
 var logging = requireNative('logging');
 var process = requireNative('process');
 var schemaRegistry = requireNative('schema_registry');
 var schemaUtils = require('schemaUtils');
 var utils = require('utils');

[lazyboy, 2017/06/27 17:51:38]

This seems to be unused now?

[Devlin, 2017/06/28 18:01:08]

Good catch; removed.

 var sendRequestHandler = require('sendRequest');
 
 var contextType = process.GetContextType();
 var extensionId = process.GetExtensionId();
 var manifestVersion = process.GetManifestVersion();
 var sendRequest = sendRequestHandler.sendRequest;
 
 // Stores the name and definition of each API function, with methods to
 // modify their behaviour (such as a custom way to handle requests to the
 // API, a custom callback, etc).
@@ skipping 475 matching lines @@
           // as "WINDOW_ID_NONE": { "value": -1 }. We handle this here.
           // TODO(kalman): enforce that things with a "value" property can't
           // define their own types.
           var type = propertyDef.type || typeof(value);
           if (type === 'integer' || type === 'number') {
             value = parseInt(value);
           } else if (type === 'boolean') {
             value = value === 'true';
           } else if (propertyDef['$ref']) {
             var ref = propertyDef['$ref'];
-            var type = utils.loadTypeSchema(propertyDef['$ref'], schema);
+            var type = loadTypeSchema(propertyDef['$ref'], schema);
             logging.CHECK(type, 'Schema for $ref type ' + ref + ' not found');
             var constructor = createCustomType(type);
             var args = value;
             logging.DCHECK($Array.isArray(args));
             $Array.push(args, type);
             // For an object propertyDef, |value| is an array of constructor
             // arguments, but we want to pass the arguments directly (i.e.
             // not as an array), so we have to fake calling |new| on the
             // constructor.
             value = { __proto__: constructor.prototype };
@@ skipping 46 matching lines @@
                     availability.message);
       return;
     }
 
     this.runHooks_(mod, schema);
     return mod;
   }
 };
 
 exports.$set('Binding', Binding);