Hide handwriting and voice buttons when keyboard is in restricted state

ui/base/ime/chromeos/input_method_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_IME_CHROMEOS_INPUT_METHOD_MANAGER_H_
 #define UI_BASE_IME_CHROMEOS_INPUT_METHOD_MANAGER_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 47 matching lines @@
     std::string label;
     MenuItemStyle style;
     bool visible;
     bool enabled;
     bool checked;
 
     unsigned int modified;
     std::vector<MenuItem> children;
   };
 
+  enum FeaturesRestricted {
+    NONE = 0,
+    EMOJI = 1 << 0,

[James Cook, 2017/06/27 16:31:11]

If you use enum instead of enum class these should all be FEATURE_EMOJI,
FEATURE_HANDWRITING, etc.

[Azure Wei, 2017/06/29 16:37:03]

Done.

+    HANDWRITING = 1 << 1,
+    VOICE = 1 << 2,
+  };
+
   class Observer {
    public:
     virtual ~Observer() {}
     // Called when the current input method is changed.  |show_message|
     // indicates whether the user should be notified of this change.
     virtual void InputMethodChanged(InputMethodManager* manager,
                                     Profile* profile,
                                     bool show_message) = 0;
   };
 
@@ skipping 234 matching lines @@
   // is different from previous.
   virtual void MaybeNotifyImeMenuActivationChanged() = 0;
 
   // Overrides the keyboard url ref (stuff following '#' to the end of the
   // string) with the given keyset (emoji, hwt or voice). If |keyset| is empty,
   // it indicates that we should override the url back with the keyboard keyset.
   virtual void OverrideKeyboardUrlRef(const std::string& keyset) = 0;
 
   // Returns whether the extra inputs: emoji, handwriting and voice inputs on
   // opt-in IME menu has been enabled.
   virtual bool IsEmojiHandwritingVoiceOnImeMenuEnabled() = 0;

[James Cook, 2017/06/27 16:31:11]

This function partially duplicates GetFeaturesRestricted(). I think it would be
better to remove this function and use GetFeatureEnabled() or
GetImeMenuFeatureEnabled().

[Azure Wei, 2017/06/29 16:37:03]

This is a different condition. IsEmojiHandwritingVoiceOnImeMenuEnabled() is for
getting the feature flag whether to show bottom (e/h/v) buttons if possible.

If IsEmojiHandwritingVoiceOnImeMenuEnabled() is false, e/h/v buttons will never
be shown on the opt-in ImeMenuTray even all features are 'not restricted'.

+
+  // Sets some advanced features, e.g. handwiring, voices input, in restricted
+  // state.
+  virtual void SetFeaturesRestricted(FeaturesRestricted feature,

[James Cook, 2017/06/27 16:31:11]

Please use positive sense booleans, so SetFeatureEnabled() or
SetImeMenuFeatureEnabled(). go/tott-387

[Azure Wei, 2017/06/29 16:37:03]

Done.

+                                     bool restricted) = 0;
+
+  // Returns the restricted state of the given keyboard feature.
+  virtual bool GetFeaturesRestricted(FeaturesRestricted feature) const = 0;

[James Cook, 2017/06/27 16:31:11]

GetFeatureEnabled() or GetImeMenuFeatureEnabled()

[Azure Wei, 2017/06/29 16:37:03]

Done.

 };
 
 }  // namespace input_method
 }  // namespace chromeos
 
 #endif  // UI_BASE_IME_CHROMEOS_INPUT_METHOD_MANAGER_H_