Hide handwriting and voice buttons when keyboard is in restricted state

extensions/browser/api/virtual_keyboard/virtual_keyboard_api.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/virtual_keyboard/virtual_keyboard_api.h"
 
 #include <memory>
 
 #include "extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h"
 #include "extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h"
 #include "extensions/common/api/virtual_keyboard.h"
 
+#if defined(OS_CHROMEOS)
+#include "ui/base/ime/chromeos/input_method_manager.h"
+using chromeos::input_method::InputMethodManager;
+#endif
+
 namespace extensions {
 
 VirtualKeyboardRestrictFeaturesFunction::
     VirtualKeyboardRestrictFeaturesFunction() {}
 
 ExtensionFunction::ResponseAction
 VirtualKeyboardRestrictFeaturesFunction::Run() {
   std::unique_ptr<api::virtual_keyboard::RestrictFeatures::Params> params(
       api::virtual_keyboard::RestrictFeatures::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   bool features_enabled = params->restrictions.auto_correct_enabled;
   if (params->restrictions.auto_complete_enabled != features_enabled ||
       params->restrictions.spell_check_enabled != features_enabled ||
       params->restrictions.voice_input_enabled != features_enabled ||
       params->restrictions.handwriting_enabled != features_enabled) {
     return RespondNow(

[James Cook, 2017/06/27 16:31:11]

Won't this function early-exit if the features have different values? Then your
code below won't run and you can't set the features individually.

[Azure Wei, 2017/06/29 16:37:03]

Yes, this will early-exit. The current API doesn't support different features
with different values. We just do nothing with the 'wrong call'.
But I think the API is going to support restricting features separately very
soon, which will remove the Error('') line.

[James Cook, 2017/06/29 16:48:29]

OK. Do you know who is going to fix that?

         Error("All features are expected to have the same enabled state."));
   }
   VirtualKeyboardAPI* api =
       BrowserContextKeyedAPIFactory<VirtualKeyboardAPI>::Get(browser_context());
   api->delegate()->SetKeyboardRestricted(!features_enabled);
+
+#if defined(OS_CHROMEOS)
+  InputMethodManager* input_method_manager = InputMethodManager::Get();
+  if (input_method_manager) {
+    input_method_manager->SetFeaturesRestricted(
+        InputMethodManager::FeaturesRestricted::VOICE,
+        params->restrictions.voice_input_enabled);

[James Cook, 2017/06/27 16:31:11]

Are you sure this is correct? You are restricting the voice feature when voice
input is enabled.

[tbarzic, 2017/06/27 17:51:19]

yeah, this looks wrong; feature should be restricted if it's not enabled.

[Azure Wei, 2017/06/29 16:37:03]

You are right, this is wrong. Corrected. Thanks!

+    input_method_manager->SetFeaturesRestricted(
+        InputMethodManager::FeaturesRestricted::HANDWRITING,
+        params->restrictions.handwriting_enabled);
+  }
+#endif
   return RespondNow(NoArguments());
 }
 
 }  // namespace extensions