Hide handwriting and voice buttons when keyboard is in restricted state

ui/base/ime/chromeos/input_method_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_IME_CHROMEOS_INPUT_METHOD_MANAGER_H_
 #define UI_BASE_IME_CHROMEOS_INPUT_METHOD_MANAGER_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 47 matching lines @@
     std::string label;
     MenuItemStyle style;
     bool visible;
     bool enabled;
     bool checked;
 
     unsigned int modified;
     std::vector<MenuItem> children;
   };
 
+  enum FeaturesRestrictedState {

[James Cook, 2017/06/26 17:21:19]

If you keep this, prefer "enum class", like FeaturesRestricted::NONE.

[Azure Wei, 2017/06/27 14:27:15]

Using 'enum class', it cannot be operanded to binary expression with uint32_t

[James Cook, 2017/06/27 16:31:10]

You can do it with static_cast<>. But I agree it's a little ugly.

Since you are not changing this to enum class, please add back a prefix to the
values, like FEATURE_EMOJI.

+    RESTRICTED_NONE = 0,
+    RESTRICTED_EMOJI = 1 << 0,
+    RESTRICTED_HANDWRITING = 1 << 1,
+    RESTRICTED_VOICE = 1 << 2,
+  };
+
   class Observer {
    public:
     virtual ~Observer() {}
     // Called when the current input method is changed.  |show_message|
     // indicates whether the user should be notified of this change.
     virtual void InputMethodChanged(InputMethodManager* manager,
                                     Profile* profile,
                                     bool show_message) = 0;
   };
 
@@ skipping 235 matching lines @@
   virtual void MaybeNotifyImeMenuActivationChanged() = 0;
 
   // Overrides the keyboard url ref (stuff following '#' to the end of the
   // string) with the given keyset (emoji, hwt or voice). If |keyset| is empty,
   // it indicates that we should override the url back with the keyboard keyset.
   virtual void OverrideKeyboardUrlRef(const std::string& keyset) = 0;
 
   // Returns whether the extra inputs: emoji, handwriting and voice inputs on
   // opt-in IME menu has been enabled.
   virtual bool IsEmojiHandwritingVoiceOnImeMenuEnabled() = 0;
+
+  // Sets some advanced features, e.g. handwiring, voices input, in restricted
+  // state.
+  virtual void SetFeaturesRestrictedState(FeaturesRestrictedState feature,

[sky, 2017/06/26 15:55:12]

How come this function doesn't take a uint32_t that is the bitmask? Do need the
functionality to toggle individual features?

[Azure Wei, 2017/06/27 14:27:15]

I want to hide the state behind. I changed GetFeaturesRestricted() as
GetFeaturesRestricted(FeatureRestricted), hope it will look better.

+                                          bool restricted) = 0;
+
+  // Returns the restricted state of the keyboard features.
+  virtual uint32_t GetFeaturesRestrictedState() = 0;
 };
 
 }  // namespace input_method
 }  // namespace chromeos
 
 #endif  // UI_BASE_IME_CHROMEOS_INPUT_METHOD_MANAGER_H_