third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp b/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

index 3322d0315aa00a46ba4df36a35b99033492a0142..47369b2c256ca81dce45510c40b6bbd71dc80bc4 100644

--- a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

@@ -332,7 +332,7 @@ static size_t FindPlainTextInternal(CharacterIteratorAlgorithm<Strategy>& it,

if (buffer.NeedsMoreContext()) {

for (SimplifiedBackwardsTextIteratorAlgorithm<Strategy> backwards_iterator(

PositionTemplate<Strategy>::FirstPositionInNode(

- it.OwnerDocument()),

+ *it.OwnerDocument()),

PositionTemplate<Strategy>(it.CurrentContainer(),

it.StartOffset()));

!backwards_iterator.AtEnd(); backwards_iterator.Advance()) {