[MarkersIntersectingRange #1] Add DocumentMarkerList::MarkersIntersectingRange()

third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DocumentMarkerListEditor_h
 #define DocumentMarkerListEditor_h
 
 #include "core/editing/markers/DocumentMarkerList.h"
 #include "platform/heap/Handle.h"
 
@@ skipping 27 matching lines @@
   static bool ShiftMarkersContentDependent(MarkerList*,
                                            unsigned offset,
                                            unsigned old_length,
                                            unsigned new_length);
 
   // Returns true if a marker was shifted or removed, false otherwise.
   static bool ShiftMarkersContentIndependent(MarkerList*,
                                              unsigned offset,
                                              unsigned old_length,
                                              unsigned new_length);
+
+  static HeapVector<Member<DocumentMarker>> MarkersIntersectingRange(

[rlanday, 2017/06/22 01:59:37]

This isn't actually an editing method, but I wasn't sure where else to put this.

I propose we rename this class to something like SortedDocumentMarkerListUtils.
All of the methods in this class only work with DocumentMarkerList
implementations that store non-overlapping markers in sorted order, which isn't
otherwise clear, and we have this non-editing method we need to put somewhere.

[yosin_UTC9, 2017/06/22 02:28:20]

I think "Editor" is better than "Utils", actually it should be "Utilities" due
by non-abbreviation rule in Blink, with 
 - Editor can do non-modification operation, e.g. find, move cursor, select,
etc.
 - Editor is shorter than "Utilities".

[Xiaocheng, 2017/06/22 03:06:06]

I'm a little skeptical about this function returning a new vector instead of a
range in the existing vector.

Too bad that WTF::Vector doesn't have a subrange class...

Should we add one?

+      const MarkerList&,
+      unsigned start_offset,
+      unsigned end_offset);
 };
 
 }  // namespace blink
 
 #endif  // DocumentMarkerListEditor_h