Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2952913002: Reland "Load service isolate from a .dill file." (Closed)

Created:
3 years, 6 months ago by sivachandra
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "Load service isolate from a .dill file." This reverts commit e90aa9cb5f03c017c1e5dbc2fa13eebc9c550453. Because of 2883d7f416296b8b7c031fb4c2d5e862b40894d4, it is expected that this change will do better on the bots. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/8b40507be30f54a610b46a2b0b74c5a25868b750

Patch Set 1 #

Patch Set 2 : Exact same patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -30 lines) Patch
M runtime/bin/dfe.h View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/bin/dfe.cc View 4 chunks +21 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 5 chunks +63 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sivachandra
3 years, 6 months ago (2017-06-22 16:54:57 UTC) #2
siva
lgtm
3 years, 6 months ago (2017-06-22 17:09:28 UTC) #3
sivachandra
3 years, 6 months ago (2017-06-22 17:10:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8b40507be30f54a610b46a2b0b74c5a25868b750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698