Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: extensions/renderer/resources/mime_handler_private_custom_bindings.js

Issue 2952893002: [Extensions Bindings] Move setHandleRequestWithPromise to util (Closed)
Patch Set: lazyboy's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/binding.js ('k') | extensions/renderer/resources/utils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/mime_handler_private_custom_bindings.js
diff --git a/extensions/renderer/resources/mime_handler_private_custom_bindings.js b/extensions/renderer/resources/mime_handler_private_custom_bindings.js
index 1fa036638db69c505843fac17fc5c44f4e616ed9..bb04683ea81fd96529b5dd0cfc9bb93d80ca6547 100644
--- a/extensions/renderer/resources/mime_handler_private_custom_bindings.js
+++ b/extensions/renderer/resources/mime_handler_private_custom_bindings.js
@@ -6,7 +6,9 @@
* Custom bindings for the mime handler API.
*/
-var binding = require('binding').Binding.create('mimeHandlerPrivate');
+var binding =
+ apiBridge || require('binding').Binding.create('mimeHandlerPrivate');
+var utils = require('utils');
var NO_STREAM_ERROR =
'Streams are only available from a mime handler view guest.';
@@ -57,17 +59,22 @@ function constructStreamInfoDict(streamInfo) {
binding.registerCustomHook(function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
- apiFunctions.setHandleRequestWithPromise('getStreamInfo', function() {
+ utils.handleRequestWithPromiseDoNotUse(
+ apiFunctions, 'mimeHandlerPrivate', 'getStreamInfo',
+ function() {
if (!streamInfoPromise)
streamInfoPromise = createStreamInfoPromise();
return streamInfoPromise.then(constructStreamInfoDict);
});
- apiFunctions.setHandleRequestWithPromise('abortStream', function() {
+ utils.handleRequestWithPromiseDoNotUse(
+ apiFunctions, 'mimeHandlerPrivate', 'abortStream',
+ function() {
return servicePromise.then(function(service) {
return service.abortStream().then(function() {});
}).catch(throwNoStreamError);
});
});
-exports.$set('binding', binding.generate());
+if (!apiBridge)
+ exports.$set('binding', binding.generate());
« no previous file with comments | « extensions/renderer/resources/binding.js ('k') | extensions/renderer/resources/utils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698