Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/analyzer/test/src/task/strong/front_end_inference_test.dart

Issue 2952873002: In strong mode, properly infer the return types of setters as `void` (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/strong/front_end_inference_test.dart
diff --git a/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart b/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart
index 19b79685e44449a343300abf5aed8a5460c91b86..4eb4a57b37e07f5b3202d0b90604e48025d6a1e3 100644
--- a/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart
+++ b/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart
@@ -457,11 +457,7 @@ class _InstrumentationVisitor extends RecursiveAstVisitor<Null> {
super.visitMethodDeclaration(node);
if (node.element.enclosingElement is ClassElement && !node.isStatic) {
if (node.returnType == null) {
- // For now, we skip inferred return types of setters.
- // TODO(paulberry): fix this.
- if (!node.isSetter) {
- _recordTopType(node.name.offset, node.element.returnType);
- }
+ _recordTopType(node.name.offset, node.element.returnType);
}
if (node.parameters != null) {
for (var parameter in node.parameters.parameters) {
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698