Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 295283003: Adding support for long values in MathUtils.clamp() (Closed)

Created:
6 years, 7 months ago by pedro (no code reviews)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding support for long values in MathUtils.clamp() BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/util/MathUtils.java View 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
pedro (no code reviews)
Hey Carson, could please review this CL?
6 years, 7 months ago (2014-05-23 22:35:56 UTC) #1
clholgat
lgtm
6 years, 7 months ago (2014-05-23 22:36:36 UTC) #2
pedro (no code reviews)
The CQ bit was checked by pedrosimonetti@chromium.org
6 years, 7 months ago (2014-05-23 22:40:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/295283003/1
6 years, 7 months ago (2014-05-23 22:42:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 02:16:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 03:17:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69634)
6 years, 7 months ago (2014-05-24 03:17:20 UTC) #7
pedro (no code reviews)
Hey David, I'm going to need this new method in my upcoming CL. Could you ...
6 years, 7 months ago (2014-05-27 17:11:34 UTC) #8
David Trainor- moved to gerrit
lgtm
6 years, 7 months ago (2014-05-27 17:41:23 UTC) #9
pedro (no code reviews)
The CQ bit was unchecked by pedrosimonetti@chromium.org
6 years, 7 months ago (2014-05-27 17:47:21 UTC) #10
pedro (no code reviews)
The CQ bit was checked by pedrosimonetti@chromium.org
6 years, 7 months ago (2014-05-27 17:47:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/295283003/1
6 years, 7 months ago (2014-05-27 17:48:28 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 17:53:28 UTC) #13
Message was sent while issue was closed.
Change committed as 272996

Powered by Google App Engine
This is Rietveld 408576698