Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: ui/app_list/views/search_box_view.h

Issue 2952763002: SearchBoxView now enables/disables cursor based on user interaction. (Closed)
Patch Set: Responded to comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/search_box_view.h
diff --git a/ui/app_list/views/search_box_view.h b/ui/app_list/views/search_box_view.h
index b03fdc6fd1886065ee1e6406064ccca6a033b74d..e21ed4f0251851c963b8304b4002172ae9f5a6ad 100644
--- a/ui/app_list/views/search_box_view.h
+++ b/ui/app_list/views/search_box_view.h
@@ -81,10 +81,22 @@ class APP_LIST_EXPORT SearchBoxView : public views::View,
// Sets voice label for Back button depending on whether a folder is open.
void SetBackButtonLabel(bool folder);
+ // Whether the cursor is being shown.
+ bool is_cursor_enabled() const { return is_cursor_enabled_; }
+
+ // Aligns the placeholder text to the left/center, changes the colour of the
+ // placeholder text, and enable/disables the cursor.
+ void SetPlaceholderTextAndEnableCursor(bool enable);
vadimt 2017/06/22 22:47:40 Please document what exactly is |enable|d
newcomer 2017/06/23 23:59:37 Adjusted the comment and renamed the bool to be mo
+
+ // Passes a mouse event to HandleMouseEvent, used for testing.
+ bool PassMouseEventForTesting(ui::MouseEvent& mouse_event);
+
// Overridden from views::View:
bool OnMouseWheel(const ui::MouseWheelEvent& event) override;
void OnEnabledChanged() override;
const char* GetClassName() const override;
+ void OnGestureEvent(ui::GestureEvent* event) override;
+ void OnMouseEvent(ui::MouseEvent* event) override;
private:
// Updates model text and selection model with current Textfield info.
@@ -98,6 +110,9 @@ class APP_LIST_EXPORT SearchBoxView : public views::View,
const base::string16& new_contents) override;
bool HandleKeyEvent(views::Textfield* sender,
const ui::KeyEvent& key_event) override;
+ bool HandleMouseEvent(views::Textfield* sender,
+ const ui::MouseEvent& mouse_event) override;
+ void NotifyOnGestureEvent() override;
vadimt 2017/06/22 22:47:40 Just "OnGesture()"
newcomer 2017/06/23 23:59:37 Just refactored to HandleGestureEvent to keep the
// Overridden from views::ButtonListener:
void ButtonPressed(views::Button* sender, const ui::Event& event) override;
@@ -128,6 +143,8 @@ class APP_LIST_EXPORT SearchBoxView : public views::View,
// Whether the fullscreen app list feature is enabled.
const bool is_fullscreen_app_list_enabled_;
+ // Whether the cursor blink is enabled.
+ bool is_cursor_enabled_;
vadimt 2017/06/22 22:47:40 Doesn't match the comment. is_cursor_blink_enabled
newcomer 2017/06/23 23:59:37 Done.
DISALLOW_COPY_AND_ASSIGN(SearchBoxView);
};

Powered by Google App Engine
This is Rietveld 408576698