Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2952743003: Fix type argument finalization of some recursive generic types (fixes #29949). (Closed)

Created:
3 years, 6 months ago by regis
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix type argument finalization of some recursive generic types (fixes #29949). Add regression test. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/eabcc23b33c3cf48a78cb9e914836eb9bd73ae5d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +6 lines, -3 lines 0 comments Download
A tests/language/regress_29949_test.dart View 1 chunk +15 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 6 months ago (2017-06-21 21:42:03 UTC) #2
siva
lgtm https://codereview.chromium.org/2952743003/diff/1/tests/language/regress_29949_test.dart File tests/language/regress_29949_test.dart (right): https://codereview.chromium.org/2952743003/diff/1/tests/language/regress_29949_test.dart#newcode15 tests/language/regress_29949_test.dart:15: } You may see failures in other tools ...
3 years, 6 months ago (2017-06-21 21:46:45 UTC) #3
regis
On 2017/06/21 21:46:45, siva wrote: > lgtm > > https://codereview.chromium.org/2952743003/diff/1/tests/language/regress_29949_test.dart > File tests/language/regress_29949_test.dart (right): > ...
3 years, 6 months ago (2017-06-21 21:53:54 UTC) #4
regis
3 years, 6 months ago (2017-06-21 21:54:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eabcc23b33c3cf48a78cb9e914836eb9bd73ae5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698