chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java - Issue 2952673002: [Payments] Format and validate phone number according to selected country in address editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java

Issue 2952673002: [Payments] Format and validate phone number according to selected country in address editor (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java » ('j') | chrome/browser/autofill/android/phone_number_util_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java

index f1d38c1d9bcce26c128a62f42ec8d549c07c73b8..f9f9d8c26932a358b2ad28915ab88d59cb3a1fd9 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java

@@ -135,7 +135,7 @@ public class PaymentRequestFreeShippingTest implements MainActivityStartCallback

0 /* Afghanistan */, mPaymentRequestTestRule.getReadyToEdit());

mPaymentRequestTestRule.setTextInEditorAndWait(

new String[] {

- "Alice", "Supreme Court", "Airport Road", "Kabul", "1043", "650-253-0000"},

+ "Alice", "Supreme Court", "Airport Road", "Kabul", "1043", "020-253-0000"},

please use gerrit instead 2017/06/20 18:48:29 Why these changes?

gogerald1 2017/06/20 19:12:40 They are invalid numbers in those countries, accor

mPaymentRequestTestRule.getEditorTextUpdate());

mPaymentRequestTestRule.clickInEditorAndWait(

R.id.payments_edit_done_button, mPaymentRequestTestRule.getReadyToPay());

@@ -146,7 +146,7 @@ public class PaymentRequestFreeShippingTest implements MainActivityStartCallback

mPaymentRequestTestRule.clickCardUnmaskButtonAndWait(

DialogInterface.BUTTON_POSITIVE, mPaymentRequestTestRule.getDismissed());

mPaymentRequestTestRule.expectResultContains(new String[] {

- "Alice", "Supreme Court", "Airport Road", "Kabul", "1043", "+16502530000"});

+ "Alice", "Supreme Court", "Airport Road", "Kabul", "1043", "+93202530000"});

}

/** Quickly pressing on "add address" and then [X] should not crash. */