Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

Issue 2952673002: [Payments] Format and validate phone number according to selected country in address editor (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
index 281c0fb4a97a4d32f719431d18dd8e8cbf05acff..2527d0ccdf902e2d1c86e82b9b219fd9d041ccdb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
@@ -485,7 +485,7 @@ public class CardEditor extends EditorBase<AutofillPaymentInstrument>
if (mNumberField == null) {
mNumberField = EditorFieldModel.createTextInput(
EditorFieldModel.INPUT_TYPE_HINT_CREDIT_CARD,
- mContext.getString(R.string.autofill_credit_card_editor_number), null,
+ mContext.getString(R.string.autofill_credit_card_editor_number), null, null,
please use gerrit instead 2017/06/20 18:48:29 Multiple nulls in a row are getting confused. Plea
gogerald1 2017/06/20 19:12:39 Done.
mCardNumberValidator, mCardIconGenerator,
mContext.getString(R.string.payments_field_required_validation_message),
mContext.getString(R.string.payments_card_number_invalid_validation_message),
@@ -510,8 +510,8 @@ public class CardEditor extends EditorBase<AutofillPaymentInstrument>
mNameField = EditorFieldModel.createTextInput(
EditorFieldModel.INPUT_TYPE_HINT_PERSON_NAME,
mContext.getString(R.string.autofill_credit_card_editor_name), null, null, null,
- mContext.getString(R.string.payments_field_required_validation_message), null,
- null);
+ null, mContext.getString(R.string.payments_field_required_validation_message),
please use gerrit instead 2017/06/20 18:48:29 Ditto.
gogerald1 2017/06/20 19:12:39 Done.
+ null, null);
}
mNameField.setValue(card.getName());
editor.addField(mNameField);

Powered by Google App Engine
This is Rietveld 408576698