Make ParseAndSetExperimentalOptions() a member of URLRequestContextConfig

components/cronet/url_request_context_config.h

Index: components/cronet/url_request_context_config.h
diff --git a/components/cronet/url_request_context_config.h b/components/cronet/url_request_context_config.h
index 6e55a92a29e665e6ed0626039ef1f67316ff76f2..b2433695d03d243e3b7e72f17ab70f950c774a14 100644
--- a/components/cronet/url_request_context_config.h
+++ b/components/cronet/url_request_context_config.h
@@ -30,6 +30,9 @@ namespace cronet {
 
 // Common configuration parameters used by Cronet to configure
 // URLRequestContext.
+// TODO(mgersh): This shouldn't be a struct. Refactor into a struct that holds
+// the data and a class that handles the logic and holds the struct, or some
+// other more reasonable way of passing around configuration.
 struct URLRequestContextConfig {
   // Type of HTTP cache.
   // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net.impl
@@ -112,6 +115,13 @@ struct URLRequestContextConfig {
       const std::string& cert_verifier_data);
   ~URLRequestContextConfig();
 
+  // Parses experimental options and makes appropriate changes to settings in
+  // the URLRequestContextConfig and URLRequestContextBuilder.
+  void ParseAndSetExperimentalOptions(

[kapishnikov, 2017/06/20 19:34:08]

This method looks internal to URLRequestContextConfig and should not exposed as
public. What other code is going to use it rather than
ConfigureURLRequestContextBuilder()?

[mgersh, 2017/06/20 21:33:57]

Made it private.

+      net::URLRequestContextBuilder* context_builder,
+      net::NetLog* net_log,
+      const scoped_refptr<base::SequencedTaskRunner>& file_task_runner);
+
   // Configures |context_builder| based on |this|.
   void ConfigureURLRequestContextBuilder(
       net::URLRequestContextBuilder* context_builder,
@@ -166,7 +176,8 @@ struct URLRequestContextConfig {
   ScopedVector<Pkp> pkp_list;
 
   // Experimental options that are recognized by the config parser.
-  std::unique_ptr<base::DictionaryValue> effective_experimental_options;
+  std::unique_ptr<base::DictionaryValue> effective_experimental_options =
+      nullptr;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(URLRequestContextConfig);