Issue 295263002: linux_aura: Use the previous font sizes on the browser actions badge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295263002: linux_aura: Use the previous font sizes on the browser actions badge. (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher

Modified:
6 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux_aura: Use the previous font sizes on the browser actions badge. The #ifdefs in badge_util.cc had the chromeos code behind OS_LINUX && TOOLKIT_VIEWS, which is no longer just chromeos. Switch that block to OS_CHROMEOS and use the old GTK+ hard coded settings in the Linux aura build. BUG=376335 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272674

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rework all the ifdefs per thestig's suggestion. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -68 lines)			Patch
	M	chrome/common/badge_util.h	View		2 chunks	+1 line, -9 lines	0 comments	Download
	M	chrome/common/badge_util.cc	View	1	2 chunks	+12 lines, -59 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm A bit more shuffling may be helpful: https://codereview.chromium.org/295263002/diff/1/chrome/common/badge_util.cc File chrome/common/badge_util.cc (right): https://codereview.chromium.org/295263002/diff/1/chrome/common/badge_util.cc#newcode21 chrome/common/badge_util.cc:21: #if ...

6 years, 7 months ago (2014-05-23 21:23:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/295263002/20001

6 years, 7 months ago (2014-05-23 21:47:21 UTC) #4

Message was sent while issue was closed.

Change committed as 272674

Expand Messages | Collapse Messages