SafeBrowsing support for WebSocket (post-network-servicification)

components/safe_browsing/renderer/websocket_sb_handshake_throttle.cc

Index: components/safe_browsing/renderer/websocket_sb_handshake_throttle.cc
diff --git a/components/safe_browsing/renderer/websocket_sb_handshake_throttle.cc b/components/safe_browsing/renderer/websocket_sb_handshake_throttle.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9077df226bcddf520fbaa4a1f38e6cb810c06c04
--- /dev/null
+++ b/components/safe_browsing/renderer/websocket_sb_handshake_throttle.cc
@@ -0,0 +1,85 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/safe_browsing/renderer/websocket_sb_handshake_throttle.h"
+
+#include <utility>
+
+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#include "base/strings/stringprintf.h"
+#include "content/public/common/content_switches.h"
+#include "content/public/common/resource_type.h"
+#include "content/public/common/service_names.mojom.h"
+#include "content/public/renderer/render_frame.h"
+#include "content/public/renderer/render_thread.h"
+#include "ipc/ipc_message.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
+#include "services/service_manager/public/cpp/connector.h"
+#include "third_party/WebKit/public/platform/WebString.h"
+#include "third_party/WebKit/public/platform/WebURL.h"
+
+namespace safe_browsing {
+
+// static
+std::unique_ptr<WebSocketSBHandshakeThrottle>
+WebSocketSBHandshakeThrottle::MaybeCreate(
+    mojom::SafeBrowsingPtr* safe_browsing_service) {
+  // TODO(ricea): Is there some way to avoid doing a string lookup every time
+  // here?
+  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableNetworkService)) {
+    return nullptr;
+  }
+  if (!*safe_browsing_service) {
+    content::RenderThread::Get()->GetConnector()->BindInterface(
+        content::mojom::kBrowserServiceName, safe_browsing_service);
+  }
+  return base::MakeUnique<WebSocketSBHandshakeThrottle>(
+      safe_browsing_service->get());
+}
+
+WebSocketSBHandshakeThrottle::WebSocketSBHandshakeThrottle(
+    mojom::SafeBrowsing* safe_browsing)
+    : callbacks_(nullptr),
+      safe_browsing_(std::move(safe_browsing)),

[kinuko, 2017/06/21 06:42:41]

nit: this std::move seems no-op

[Adam Rice, 2017/06/21 07:43:20]

Thanks, removed.

+      weak_factory_(this) {}
+
+WebSocketSBHandshakeThrottle::~WebSocketSBHandshakeThrottle() {}
+
+void WebSocketSBHandshakeThrottle::ThrottleHandshake(
+    const blink::WebURL& url,
+    blink::WebLocalFrame* web_local_frame,
+    blink::WebCallbacks<void, const blink::WebString&>* callbacks) {
+  DCHECK(!callbacks_);
+  DCHECK(!url_checker_);
+  callbacks_ = callbacks;
+  url_ = url;
+  int render_frame_id = MSG_ROUTING_NONE;
+  if (web_local_frame) {
+    render_frame_id =
+        content::RenderFrame::FromWebFrame(web_local_frame)->GetRoutingID();
+  }
+  int load_flags = 0;
+  safe_browsing_->CreateCheckerAndCheck(
+      render_frame_id, mojo::MakeRequest(&url_checker_), url, load_flags,
+      content::RESOURCE_TYPE_SUB_RESOURCE,
+      base::BindOnce(&WebSocketSBHandshakeThrottle::OnCheckResult,
+                     weak_factory_.GetWeakPtr()));
+}
+
+void WebSocketSBHandshakeThrottle::OnCheckResult(bool safe) {
+  if (safe) {
+    callbacks_->OnSuccess();
+  } else {
+    callbacks_->OnError(blink::WebString::FromUTF8(base::StringPrintf(
+        "WebSocket connection to %s failed safe browsing check",
+        url_.spec().c_str())));
+  }
+  // |this| is destroyed here.
+}
+
+}  // namespace safe_browsing