Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2952553002: Dismiss menu when infobar's host tab is hidden. (new translate infobar) (Closed)
Patch Set: use onDetached event in TranslateCompactInfoBar Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index c0e763737fbb597759c46397f8e649a581ff327d..7eceb301bd48b0b208bc2d2b2b5f4648480f82d8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -182,6 +182,17 @@ public class TranslateCompactInfoBar extends InfoBar
(LinearLayout) LayoutInflater.from(getContext())
.inflate(R.layout.infobar_translate_compact_content, parent, false);
+ // When parent tab is being switched out (view detached), dismiss all menus and snackbars.
+ content.addOnAttachStateChangeListener(new View.OnAttachStateChangeListener() {
+ @Override
+ public void onViewAttachedToWindow(View view) {}
+
+ @Override
+ public void onViewDetachedFromWindow(View view) {
+ dismissMenusAndSnackbars();
+ }
+ });
+
mTabLayout = (TranslateTabLayout) content.findViewById(R.id.translate_infobar_tabs);
mTabLayout.addTabs(mOptions.sourceLanguageName(), mOptions.targetLanguageName());
@@ -440,14 +451,19 @@ public class TranslateCompactInfoBar extends InfoBar
if (mLanguageMenuHelper != null) mLanguageMenuHelper.dismiss();
}
- @Override
- protected void onStartedHiding() {
+ // Dismiss all overflow menus and snackbars that belong to this infobar and remain open.
+ private void dismissMenusAndSnackbars() {
dismissMenus();
if (getSnackbarManager() != null && mSnackbarController != null) {
getSnackbarManager().dismissSnackbars(mSnackbarController);
}
}
+ @Override
+ protected void onStartedHiding() {
+ dismissMenusAndSnackbars();
+ }
+
/**
* Returns true if overflow menu is showing. This is only used for automation testing.
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698