Issue 295243004: Revert 272428 "Add native event testing to chromeos::EventRewrit..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295243004: Revert 272428 "Add native event testing to chromeos::EventRewrit..." (Closed)

Created:
6 years, 7 months ago by fgorski

Modified:
6 years, 7 months ago

Reviewers:
kpschoedel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 272428 "Add native event testing to chromeos::EventRewrit..." The CL introduced unit test failures on Chromium OS ASan LSan Tests(3) http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1499 Failing tests: EventRewriterTest.TestRewriteFunctionKeys EventRewriterTest.TestRewriteModifiersDisableSome > Add native event testing to chromeos::EventRewriter unit tests. > > Most tests (not having state) are converted to a table-driven form, > so that multiple test operations can be done on the same test data. > Additional tests based on X11 native events are done on these cases. > > The fallback X11 keycode to keysym mapping is expanded, because the > X server used by some automated tests does not support some of the > keycodes used by ChromeOS top-row special keys. > > > R=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/270633012 TBR=kpschoedel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272553

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+852 lines, -1009 lines)			Patch
M	trunk/src/chrome/browser/chromeos/events/event_rewriter.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/events/event_rewriter_unittest.cc	View	18 chunks	+764 lines, -853 lines	0 comments	Download
M	trunk/src/ui/events/keycodes/keyboard_code_conversion_x.cc	View	1 chunk	+88 lines, -151 lines	0 comments	Download
M	trunk/src/ui/events/test/events_test_utils_x11.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r272553.