Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: extensions/common/feature_channel_param_traits.h

Issue 2952353002: Extensions: Pass current channel and feature session type to extension unpack utility process. (Closed)
Patch Set: Nit. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_unpacker.typemap ('k') | extensions/common/feature_session_type_param_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/feature_channel_param_traits.h
diff --git a/extensions/common/feature_channel_param_traits.h b/extensions/common/feature_channel_param_traits.h
new file mode 100644
index 0000000000000000000000000000000000000000..622c61578a3dbe75890096e5827cfe85d8e682fc
--- /dev/null
+++ b/extensions/common/feature_channel_param_traits.h
@@ -0,0 +1,11 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Multiply-included header, hence no include guard.
+
+#include "components/version_info/version_info.h"
+#include "ipc/ipc_message_macros.h"
+#include "ipc/param_traits_macros.h"
+
+IPC_ENUM_TRAITS_MAX_VALUE(version_info::Channel, version_info::Channel::STABLE)
dcheng 2017/06/24 03:30:53 Hmm. Do we want to put everything in separate file
karandeepb 2017/06/26 21:51:54 I feel this is better than having a single common
dcheng1 2017/06/26 22:09:49 There's something to be said for granularity, but
karandeepb 2017/06/26 22:16:44 "just keeping it in the original location" -> This
dcheng1 2017/06/26 23:07:35 sgtm
« no previous file with comments | « extensions/common/extension_unpacker.typemap ('k') | extensions/common/feature_session_type_param_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698