Adding previews information to PLM UKM

chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc

Index: chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc b/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..501bdfcb3733711ebf597d73137783686571d6b2
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
@@ -0,0 +1,103 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/previews_ukm_observer.h"
+
+#include "base/optional.h"
+#include "base/time/time.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/loader/chrome_navigation_data.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
+#include "chrome/common/page_load_metrics/page_load_timing.h"
+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h"
+#include "components/ukm/public/ukm_entry_builder.h"
+#include "components/ukm/public/ukm_recorder.h"
+#include "components/ukm/ukm_source.h"
+#include "content/public/browser/navigation_handle.h"
+
+namespace previews {
+
+namespace {
+
+const char kPreviewsName[] = "Previews";
+const char kPreviewsType[] = "previews_type";
+
+}  // namespace
+
+PreviewsUKMObserver::PreviewsUKMObserver() {}
+
+PreviewsUKMObserver::~PreviewsUKMObserver() {}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+PreviewsUKMObserver::OnCommit(content::NavigationHandle* navigation_handle,
+                              ukm::SourceId source_id) {
+  // As documented in content/public/browser/navigation_handle.h, this
+  // NavigationData is a clone of the NavigationData instance returned from
+  // ResourceDispatcherHostDelegate::GetNavigationData during commit.
+  // Because ChromeResourceDispatcherHostDelegate always returns a
+  // ChromeNavigationData, it is safe to static_cast here.
+  ChromeNavigationData* chrome_navigation_data =
+      static_cast<ChromeNavigationData*>(
+          navigation_handle->GetNavigationData());
+  if (!chrome_navigation_data)
+    return CONTINUE_OBSERVING;
+  data_reduction_proxy::DataReductionProxyData* data =
+      chrome_navigation_data->GetDataReductionProxyData();
+  if (data && data->used_data_reduction_proxy() && data->lite_page_received()) {
+    previews_types_ |= PREVIEWS_UKM_LITE_PAGE;
+  }
+
+  return CONTINUE_OBSERVING;
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+PreviewsUKMObserver::OnStart(content::NavigationHandle* navigation_handle,
+                             const GURL& currently_committed_url,
+                             bool started_in_foreground) {
+  if (!started_in_foreground)
+    return STOP_OBSERVING;
+  return CONTINUE_OBSERVING;
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+PreviewsUKMObserver::FlushMetricsOnAppEnterBackground(
+    const page_load_metrics::mojom::PageLoadTiming& timing,
+    const page_load_metrics::PageLoadExtraInfo& info) {
+  RecordPreviewsTypes(info);
+  return STOP_OBSERVING;
+}
+
+void PreviewsUKMObserver::OnComplete(
+    const page_load_metrics::mojom::PageLoadTiming& timing,
+    const page_load_metrics::PageLoadExtraInfo& info) {
+  RecordPreviewsTypes(info);
+}
+
+void PreviewsUKMObserver::RecordPreviewsTypes(
+    const page_load_metrics::PageLoadExtraInfo& info) {
+  if (previews_types_ == PREVIEWS_UKM_NONE)
+    return;
+  ukm::UkmRecorder* ukm_recorder = g_browser_process->ukm_recorder();

[Bryan McQuade, 2017/06/28 13:13:40]

i think you may need to check that ukm_recorder is non-null here, though rkaplow
can say for sure.

[RyanSturm, 2017/07/11 21:46:40]

Done.

+  std::unique_ptr<ukm::UkmEntryBuilder> builder =
+      ukm_recorder->GetEntryBuilder(info.source_id, kPreviewsName);
+  builder->AddMetric(kPreviewsType, previews_types_);
+}
+
+void PreviewsUKMObserver::OnLoadedResource(
+    const page_load_metrics::ExtraRequestCompleteInfo&
+        extra_request_complete_info) {
+  if (extra_request_complete_info.data_reduction_proxy_data) {
+    if (extra_request_complete_info.data_reduction_proxy_data
+            ->lofi_received()) {
+      previews_types_ |= PREVIEWS_UKM_SERVER_LOFI;
+    }
+    if (extra_request_complete_info.data_reduction_proxy_data
+            ->client_lofi_requested()) {
+      previews_types_ |= PREVIEWS_UKM_CLIENT_LOFI;
+    }
+  }
+}
+
+}  // namespace previews