chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc - Issue 2952343004: Adding previews information to PLM UKM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc

Issue 2952343004: Adding previews information to PLM UKM (Closed)

Patch Set: stop observing on background Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/previews_ukm_observer.h » ('j') | chrome/browser/page_load_metrics/observers/previews_ukm_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc

index 20efc021378125d642ddc4c9da13fe6f8146b239..1f636f2e14d63877ac3df240e0f8cdc97f8a8c09 100644

--- a/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc

@@ -314,7 +314,7 @@ TEST_F(LoFiPageLoadMetricsObserverTest, BothLoFiSeen) {

std::unique_ptr<DataReductionProxyData> data2 =

base::MakeUnique<DataReductionProxyData>();

data2->set_used_data_reduction_proxy(true);

- data2->set_lofi_received(true);

+ data2->set_client_lofi_requested(true);

// Prepare 4 resources of varying size and configurations, 1 has Client LoFi,

// 1 has Server LoFi.