chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2952343004: Adding previews information to PLM UKM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2952343004: Adding previews information to PLM UKM (Closed)

Patch Set: change over tests + adding booleans instead of bitmask Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 1c0c832cf8765c61f1a60cc83bc1fc34df6b6a28..9187e0b91f3b8b15a4b0e16f4aefffd967d7ea52 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -34,6 +34,7 @@

#include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/previews_ukm_observer.h"

#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"

@@ -98,6 +99,7 @@ void PageLoadMetricsEmbedder::RegisterObservers(

base::MakeUnique<MultiTabLoadingPageLoadMetricsObserver>());

tracker->AddObserver(

base::MakeUnique<previews::PreviewsPageLoadMetricsObserver>());

+ tracker->AddObserver(base::MakeUnique<previews::PreviewsUKMObserver>());

tracker->AddObserver(

base::MakeUnique<ServiceWorkerPageLoadMetricsObserver>());

tracker->AddObserver(base::MakeUnique<SubresourceFilterMetricsObserver>());