EG Tests for Sad Tab View

ios/chrome/browser/ui/sad_tab/sad_tab_view_egtest.mm

Index: ios/chrome/browser/ui/sad_tab/sad_tab_view_egtest.mm
diff --git a/ios/chrome/browser/ui/sad_tab/sad_tab_view_egtest.mm b/ios/chrome/browser/ui/sad_tab/sad_tab_view_egtest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..9f06063b8facc57516692ac31ee0a4f5dc6d9dbe
--- /dev/null
+++ b/ios/chrome/browser/ui/sad_tab/sad_tab_view_egtest.mm
@@ -0,0 +1,158 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <EarlGrey/EarlGrey.h>
+#import <XCTest/XCTest.h>
+
+#include "base/ios/ios_util.h"
+#include "components/strings/grit/components_strings.h"
+#include "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h"
+#import "ios/chrome/test/app/chrome_test_util.h"
+#import "ios/chrome/test/app/navigation_test_util.h"
+#import "ios/chrome/test/earl_grey/chrome_assertions.h"
+#import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
+#import "ios/chrome/test/earl_grey/chrome_earl_grey_ui.h"
+#import "ios/chrome/test/earl_grey/chrome_matchers.h"
+#import "ios/chrome/test/earl_grey/chrome_test_case.h"
+#import "ios/web/public/test/http_server/http_server.h"
+#include "ios/web/public/test/http_server/http_server_util.h"
+#include "ui/base/l10n/l10n_util_mac.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+namespace {
+// Returns matcher that looks for text in UILabel, UITextView, and UITextField
+// objects, checking if their displayed strings contain the provided |text|.
+id<GREYMatcher> ContainsText(NSString* text) {
+  MatchesBlock matches = ^BOOL(id element) {
+    return [[element text] containsString:text];
+  };
+  DescribeToBlock describe = ^void(id<GREYDescription> description) {
+    [description appendText:[NSString stringWithFormat:@"hasText('%@')", text]];
+  };
+  id<GREYMatcher> matcher =
+      [[GREYElementMatcherBlock alloc] initWithMatchesBlock:matches
+                                           descriptionBlock:describe];
+  return grey_allOf(grey_anyOf(grey_kindOfClass([UILabel class]),
+                               grey_kindOfClass([UITextField class]),
+                               grey_kindOfClass([UITextView class]), nil),
+                    matcher, nil);
+}
+
+// A matcher for the main title of the Sad Tab in 'reload' mode.
+id<GREYMatcher> reloadSadTabTitleText() {
+  static id matcher = nil;
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    matcher = [GREYMatchers
+        matcherForText:l10n_util::GetNSString(IDS_SAD_TAB_MESSAGE)];
+  });
+  return matcher;

[baxley, 2017/06/27 06:02:11]

Question more than comment, why is dispatch_once needed here? In our other
matchers, we typically just return the matcher.

For example...
return grey_text(l10n_util::GetNSString(IDS_SAD_TAB_MESSAGE);

I'm asking in case there is a bug we've missed, or I'm missing how this is
different from other matchers.

[PL, 2017/06/27 23:21:46]

Good question!

If you look at the GREYMatchers implementation, the convenience methods that
return matchers (e.g. matcherForText:) create and allocate a new matcher every
call.

That's unnecessary, so here a dispatch_once ensures we re-use the matcher for
the multiple times it's needed. dispatch_once is very quick and thread-safe
(even though those things aren't super high priorities in the case of an
egtest).

+}
+
+// A matcher for the main title of the Sad Tab in 'feedback' mode.
+id<GREYMatcher> feedbackSadTabTitleContainsText() {
+  static id matcher = nil;
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    matcher = ContainsText(l10n_util::GetNSString(IDS_SAD_TAB_RELOAD_TRY));
+  });
+  return matcher;
+}
+
+// A matcher for a help string suggesting the user use Incognito Mode.
+id<GREYMatcher> incognitoHelpContainsText() {
+  static id matcher = nil;
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    matcher =
+        ContainsText(l10n_util::GetNSString(IDS_SAD_TAB_RELOAD_INCOGNITO));
+  });
+  return matcher;
+}
+}
+
+// Sad Tab View integration tests for Chrome.
+@interface SadTabViewTestCase : ChromeTestCase
+@end
+
+@implementation SadTabViewTestCase
+
+// Verifies initial and repeated visits to the Sad Tab.
+// N.B. There is a mechanism which changes the Sad Tab UI if a crash URL is
+// visited within 60 seconds, for this reason this one test can not
+// be easily split up across multiple tests
+// as visiting Sad Tab may not be idempotent.
+- (void)testSadTabView {
+  // Prepare a simple but known URL to avoid testing from the NTP.
+  web::test::SetUpFileBasedHttpServer();
+  const GURL simple_URL = web::test::HttpServer::MakeUrl(
+      "http://ios/testing/data/http_server_files/destination.html");
+
+  // Prepare a helper block to test Sad Tab navigating from and to normal pages.
+  void (^loadAndCheckSimpleURL)() = ^void() {
+    [ChromeEarlGrey loadURL:simple_URL];
+    [ChromeEarlGrey waitForWebViewContainingText:"You've arrived"];
+    [[EarlGrey selectElementWithMatcher:reloadSadTabTitleText()]
+        assertWithMatcher:grey_nil()];
+    [[EarlGrey selectElementWithMatcher:feedbackSadTabTitleContainsText()]
+        assertWithMatcher:grey_nil()];
+  };
+
+  loadAndCheckSimpleURL();
+
+  // Navigate to the chrome://crash URL which should show the Sad Tab.
+  // Use chome_test_util::LoadURL() directly to avoid ChomeEarlGrey helper

[baxley, 2017/06/27 06:02:11]

sorry for the super-nit...
is it chrome_test_util::LoadUrl()

[PL, 2017/06/27 23:21:46]

Yes! I love the super-nit don't worry, helps me look like I can spell :-).

+  // methods which expect to wait for web content.
+  const GURL crash_URL = GURL("chrome://crash");
+  chrome_test_util::LoadUrl(crash_URL);
+  [[EarlGrey selectElementWithMatcher:reloadSadTabTitleText()]
+      assertWithMatcher:grey_notNil()];
+
+  // Ensure user can navigate away from Sad Tab, and the Sad Tab content
+  // is no longer visible.
+  loadAndCheckSimpleURL();
+
+  // A second visit to the crashing URL should show a feedback message.
+  // It should also show help messages including an invitation to use
+  // Incognito Mode.
+  chrome_test_util::LoadUrl(crash_URL);
+  [[EarlGrey selectElementWithMatcher:feedbackSadTabTitleContainsText()]
+      assertWithMatcher:grey_notNil()];
+  [[EarlGrey selectElementWithMatcher:incognitoHelpContainsText()]
+      assertWithMatcher:grey_notNil()];
+
+  // Again ensure a user can navigate away from Sad Tab, and the Sad Tab content
+  // is no longer visible.
+  loadAndCheckSimpleURL();
+
+  // Open an Incognito tab and browse somewhere, the repeated crash UI changes
+  // dependent on the Incognito mode.
+  [ChromeEarlGreyUI openToolsMenu];
+  id<GREYMatcher> newIncognitoTabButtonMatcher =
+      grey_accessibilityID(kToolsMenuNewIncognitoTabId);
+  [[EarlGrey selectElementWithMatcher:newIncognitoTabButtonMatcher]
+      performAction:grey_tap()];
+  chrome_test_util::AssertIncognitoTabCount(1);
+  loadAndCheckSimpleURL();
+
+  // Test an initial crash, and then a second crash in Incognito mode, as above.
+  // Incognito mode should not be suggested if already in Incognito mode.
+  chrome_test_util::LoadUrl(crash_URL);
+  [[EarlGrey selectElementWithMatcher:reloadSadTabTitleText()]
+      assertWithMatcher:grey_notNil()];
+  chrome_test_util::LoadUrl(crash_URL);
+  [[EarlGrey selectElementWithMatcher:feedbackSadTabTitleContainsText()]
+      assertWithMatcher:grey_notNil()];
+  [[EarlGrey selectElementWithMatcher:incognitoHelpContainsText()]
+      assertWithMatcher:grey_nil()];
+
+  // Finally, ensure that the user can browse away from the Sad Tab page
+  // in Incognito Mode.
+  loadAndCheckSimpleURL();
+}
+
+@end