EG Tests for Sad Tab View

ios/chrome/test/earl_grey/chrome_matchers.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_TEST_EARL_GREY_CHROME_MATCHERS_H_
 #define IOS_CHROME_TEST_EARL_GREY_CHROME_MATCHERS_H_
 
 #include <string>
 
 #import <EarlGrey/EarlGrey.h>
@@ skipping 108 matching lines @@
 
 // Returns matcher for the menu button to sync accounts.
 id<GREYMatcher> AccountsSyncButton();
 
 // Returns matcher for the Content Settings button on the main Settings screen.
 id<GREYMatcher> ContentSettingsButton();
 
 // Returns matcher for the back button on a settings menu.
 id<GREYMatcher> SettingsMenuBackButton();
 
+// Returns matcher that looks for text in UILabel, UITextView, and UITextField
+// objects. The text comparison is performed with NSString's containsText:

[baxley, 2017/06/26 08:25:37]

Is it worthwhile exposing the implementation detail of the method used? Or would
it be better to just say that it looks for a substring of text in UILabel, ... ?

[PL, 2017/06/26 23:51:47]

Done!

+// method.
+id<GREYMatcher> ContainsText(NSString* text);

[baxley, 2017/06/26 08:25:37]

Can you think of many other use cases where this is needed over matcherForText
in GREYMatchers.h? I think that one is preferable, when it works.

I'd rather not have two slightly different helper methods in different
locations, making it more difficult to know which to use, unless the need for
ContainsText expands beyond the test you added. There may already be examples
doing something similar within tests, in which case this method is a good idea.

[PL, 2017/06/26 23:51:47]

I was a bit surprised this was the first time this would be needed, I had a look
through to see if there were similar tests using something like this but in a
brief look through - I didn't see any but there are a lot I did not check.

I'm happy to move this into the test class so it isn't presented to everyone,
but I can imagine it being useful in the future. Happy to take your guidance and
move it into the test class, I've done that in the new patch so you can see how
it might look :-).

+
 }  // namespace chrome_test_util
 
 #endif  // IOS_CHROME_TEST_EARL_GREY_CHROME_MATCHERS_H_