Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: pkg/analysis_server/lib/src/protocol/protocol_internal.dart

Issue 2952233002: Fix hints and clean-up obsolete comment syntax (TBR) (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/protocol/protocol_internal.dart
diff --git a/pkg/analysis_server/lib/src/protocol/protocol_internal.dart b/pkg/analysis_server/lib/src/protocol/protocol_internal.dart
index 0d6799d96f669c4a6fb1f4097a9ced346cd504e1..1212a591d6338996d4a1fb12f45f264043775772 100644
--- a/pkg/analysis_server/lib/src/protocol/protocol_internal.dart
+++ b/pkg/analysis_server/lib/src/protocol/protocol_internal.dart
@@ -136,22 +136,21 @@ bool mapEqual(Map mapA, Map mapB, bool valueEqual(a, b)) {
* Translate the input [map], applying [keyCallback] to all its keys, and
* [valueCallback] to all its values.
*/
-Map/*<KR, VR>*/ mapMap/*<KP, VP, KR, VR>*/(Map/*<KP, VP>*/ map,
- {dynamic/*=KR*/ keyCallback(/*<KP>*/ key),
- dynamic/*=VR*/ valueCallback(/*<VP>*/ value)}) {
- Map/*<KR, VR>*/ result = new HashMap/*<KR, VR>*/();
+Map<KR, VR> mapMap<KP, VP, KR, VR>(Map<KP, VP> map,
+ {KR keyCallback(KP key), VR valueCallback(VP value)}) {
+ Map<KR, VR> result = new HashMap<KR, VR>();
map.forEach((key, value) {
- Object/*=KR*/ resultKey;
- Object/*=VR*/ resultValue;
+ KR resultKey;
+ VR resultValue;
if (keyCallback != null) {
resultKey = keyCallback(key);
} else {
- resultKey = key as Object/*=KR*/;
+ resultKey = key as KR;
}
if (valueCallback != null) {
resultValue = valueCallback(value);
} else {
- resultValue = value as Object/*=VR*/;
+ resultValue = value as VR;
}
result[resultKey] = resultValue;
});
« no previous file with comments | « pkg/analysis_server/lib/src/domain_analysis.dart ('k') | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698