Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2952113002: add Parser.withoutFasta constructor (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add Parser.withoutFasta constructor This renames an existing private Parser constructor as a short term fix so that the angular plugin can extend the Parser. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ebdc0eda119df068d4736012c64db67717214a70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 6 months ago (2017-06-22 01:16:09 UTC) #2
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-06-22 04:29:22 UTC) #3
danrubel
3 years, 6 months ago (2017-06-22 13:41:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebdc0eda119df068d4736012c64db67717214a70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698