Issue 295203002: Fixed sync regression for ephemeral apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295203002: Fixed sync regression for ephemeral apps (Closed)

Created:
6 years, 7 months ago by tmdiep

Modified:
6 years, 7 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fixed sync regression for ephemeral apps r272157 introduced a regression where ephemeral apps would be synced when Chrome restarts, causing them to be installed. BUG=374018 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272855

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -10 lines)			Patch
M	chrome/browser/extensions/app_sync_bundle.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_sync_service.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_sync_service.cc	View	5 chunks	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_util.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_util.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

tmdiep

This fixes a regression that I introduced in the previous large patch (https://codereview.chromium.org/282103003). Thanks!

6 years, 7 months ago (2014-05-23 02:48:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/295203002/1

6 years, 7 months ago (2014-05-26 03:39:12 UTC) #4

Message was sent while issue was closed.

Change committed as 272855