Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4829)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

Issue 2952023002: Change WebApk app-id prefix from 'webapk:' to 'webapk-' (Closed)
Patch Set: fix test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDirectoryManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
index 0758d2a5bbee8819d1caad7d485932ffc7cf5d71..f55a8956132718e02423967b7bb15ed1e9d2f1c3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
@@ -15,6 +15,7 @@ import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.browser.banners.InstallerDelegate;
import org.chromium.chrome.browser.browsing_data.UrlFilter;
import org.chromium.chrome.browser.browsing_data.UrlFilterBridge;
+import org.chromium.webapk.lib.common.WebApkConstants;
import java.util.Collections;
import java.util.HashMap;
@@ -193,7 +194,11 @@ public class WebappRegistry {
WebappDataStorage storage = entry.getValue();
String webApkPackage = storage.getWebApkPackageName();
if (webApkPackage != null) {
- if (isWebApkInstalled(webApkPackage)) {
+ // Prefix check that the key matches the current scheme instead of an old
+ // deprecated naming scheme and that the WebApk is still installed. The former is
+ // necessary as we migrate away from the old naming scheme and garbage collect.
+ if (entry.getKey().startsWith(WebApkConstants.WEBAPK_ID_PREFIX)
+ && isWebApkInstalled(webApkPackage)) {
continue;
}
} else if ((currentTime - storage.getLastUsedTime())
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDirectoryManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698