Issue 2952006: WifiConfigView::Init(): Fetch the localized string for the cert...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2952006: WifiConfigView::Init(): Fetch the localized string for the cert... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Nathan Williams

Modified:
4 years ago

Reviewers:
stevenjb

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, Charlie Lee

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

WifiConfigView::Init(): Fetch the localized string for the cert button, rather than using the cert button ID directly, which produces garbage. BUG=http://crosbug.com/4490 TEST=Click network dropdown and select a 802.1x network that has not been configured by the system (google-A when logged in to a non-corp account, for example). Check that the button to the right of the "Certificate:" label contains text ("Select certificate file"), rather than the not-a-character glyph. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52700

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/chromeos/options/wifi_config_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stevenjb

4 years, 10 months ago (2010-07-13 20:14:35 UTC) #2

On 2010/07/13 19:44:58, Nathan Williams wrote:
> 

lgtm.

I will push this shortly.

Expand Messages | Collapse Messages