Issue 2952004: [Mac] Finish implementation of App Tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2952004: [Mac] Finish implementation of App Tabs. (Closed)

Created:
10 years, 5 months ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Finish implementation of App Tabs. This takes into account the UI consolidation of pinned and nano tabs tracked in issue 49013. TEST=none BUG=45539, 49013 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52394

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -59 lines)			Patch
M	chrome/browser/cocoa/browser_window_cocoa.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.mm	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	1 2 3 4	2 chunks	+1 line, -13 lines	0 comments	Download
M	chrome/browser/cocoa/tab_controller.mm	View	1 2 3 4	4 chunks	+5 lines, -8 lines	1 comment	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	1 2 3 4	4 chunks	+16 lines, -13 lines	0 comments	Download
M	chrome/browser/cocoa/tab_view.mm	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.h	View		1 chunk	+1 line, -1 line	1 comment	Download
M	chrome/browser/tab_menu_model.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_menu_model.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 5 months ago (2010-07-14 18:40:27 UTC) #1

LGTM

http://codereview.chromium.org/2952004/diff/13001/14005
File chrome/browser/cocoa/tab_controller.mm (right):

http://codereview.chromium.org/2952004/diff/13001/14005#newcode134
chrome/browser/cocoa/tab_controller.mm:134: false,  // allow_toolbar_toggle
OCD: line up the comments.

http://codereview.chromium.org/2952004/diff/13001/14008
File chrome/browser/cocoa/toolbar_controller.h (right):

http://codereview.chromium.org/2952004/diff/13001/14008#newcode33
chrome/browser/cocoa/toolbar_controller.h:33: }  // ToolbarControllerInternal
// namespace ToolbarControllerInternal

Expand Messages | Collapse Messages