Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4414)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_request_manager_unittest.cc

Issue 2952003003: Log site engagement scores for permission actions (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/permissions/permission_request_manager.cc ('K') | « chrome/browser/permissions/permission_request_manager.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_request_manager_unittest.cc
diff --git a/chrome/browser/permissions/permission_request_manager_unittest.cc b/chrome/browser/permissions/permission_request_manager_unittest.cc
index 559ea5eb39b4c225b72815f4ee72388895e4a07a..9f6f024cb509e2f698d6bfb1ad283ab7867e3a28 100644
--- a/chrome/browser/permissions/permission_request_manager_unittest.cc
+++ b/chrome/browser/permissions/permission_request_manager_unittest.cc
@@ -34,12 +34,14 @@ class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {
request_camera_("cam",
PermissionRequestType::PERMISSION_MEDIASTREAM_CAMERA,
PermissionRequestGestureType::NO_GESTURE),
- iframe_request_same_domain_("iframe",
- PermissionRequestType::UNKNOWN,
- GURL("http://www.google.com/some/url")),
- iframe_request_other_domain_("iframe",
- PermissionRequestType::UNKNOWN,
- GURL("http://www.youtube.com")),
+ iframe_request_same_domain_(
+ "iframe",
+ PermissionRequestType::PERMISSION_NOTIFICATIONS,
+ GURL("http://www.google.com/some/url")),
+ iframe_request_other_domain_(
+ "iframe",
+ PermissionRequestType::PERMISSION_GEOLOCATION,
+ GURL("http://www.youtube.com")),
iframe_request_mic_other_domain_(
"iframe",
PermissionRequestType::PERMISSION_MEDIASTREAM_MIC,
« chrome/browser/permissions/permission_request_manager.cc ('K') | « chrome/browser/permissions/permission_request_manager.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698